Skip to content

Conversation

@erikjanwestendorp
Copy link
Contributor

@erikjanwestendorp erikjanwestendorp commented Oct 24, 2024

Description

This PR belongs to: #6466.

  • Change UmbracoApiController to Controller
  • Remove using statement using Umbraco.Cms.Web.Common.Controllers;
  • Add Attributes
  • Change IComponent to NotificationHandler

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version

Product & version (if relevant)

Umbraco CMS v14 & 15

@erikjanwestendorp erikjanwestendorp changed the title Porting old Umbraco API Controller [Getting started with Entity Framework (EF) Core] Porting old Umbraco API Controller [Relation Service] Oct 24, 2024
@sofietoft
Copy link
Contributor

Thanks @erikjanwestendorp ! 💪

I'll make sure we review this as soon as possible.

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @erikjanwestendorp !

I've made a single suggestion to remove the note before the Controller code snippet.

@erikjanwestendorp
Copy link
Contributor Author

@sofietoft Just updated the PR with your suggestion 😄

@sofietoft sofietoft merged commit 99a0b68 into umbraco:main Oct 31, 2024
40 of 46 checks passed
@erikjanwestendorp erikjanwestendorp deleted the update-relation-service branch October 31, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants